-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libguestfs: remove xen as dependency #108882
Conversation
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 5 packages built:
The following issues got detected with the above build packages. python37Packages.guestfs: Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested, working fine, also Vagrants with libvirtd too.
Result of 3 packages marked as broken and skipped:
|
Motivation for this change
Xen is not a dependency of Libguestfs, so this PR removes Xen from libguestfs dependencies. It also uses autoconf 2.64 instead of the last one in Nix, because it's not building with the last version.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)