Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpkg: fix the build on Darwin #10934

Merged
merged 1 commit into from
Sep 5, 2016
Merged

dpkg: fix the build on Darwin #10934

merged 1 commit into from
Sep 5, 2016

Conversation

benley
Copy link
Member

@benley benley commented Nov 10, 2015

Borrowed some hints from homebrew's formula.

@domenkozar domenkozar added the 6.topic: darwin Running or building packages on Darwin label Nov 10, 2015
@benley
Copy link
Member Author

benley commented Nov 10, 2015

build failure is unrelated to this change (it's devscripts - I'll fix that too)

@benley
Copy link
Member Author

benley commented Nov 10, 2015

This PR now supersedes #10935 as well

@benley benley mentioned this pull request Nov 10, 2015
@bjornfor
Copy link
Contributor

@benley: I tried to merge it, but it appears the packages have been updated to newer versions in the meantime.

I think the only useful bit remaining in this PR is this part from dpkg:

+     (stdenv.lib.optionalString stdenv.isDarwin "--disable-linker-optimisations")
+     (stdenv.lib.optionalString stdenv.isDarwin "--disable-start-stop-daemon")

(Although I don't know how important that part is.)

Please have a look and either rebase/close/open new PR.

@benley
Copy link
Member Author

benley commented May 21, 2016

Thanks for reminding me - I'll take another look at this PR and either update or close it.

@joachifm
Copy link
Contributor

joachifm commented Sep 4, 2016

@benley ping :)

There are still some bugs and quirks, but this gets dpkg building at
least, and some parts of it are useful.
@benley
Copy link
Member Author

benley commented Sep 5, 2016

revived! I hella forgot about this again.

@benley benley merged commit 7693fc2 into NixOS:master Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants