multimc: Update to latest development build #110439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
8.has: documentation
labels
pkgs/games/multimc/default.nix
Outdated
| @@ -34,6 +34,6 @@ in mkDerivation rec { | |||
| ''; | |||
| platforms = platforms.linux; | |||
| license = licenses.lgpl21Plus; | |||
| maintainers = [ maintainers.cleverca22 ]; | |||
| maintainers = [ maintainers.cleverca22 maintainers.starcraft66 ]; | |||
There was a problem hiding this comment.
Suggested change
| maintainers = [ maintainers.cleverca22 maintainers.starcraft66 ]; | |
| maintainers = with maintainers; [ cleverca22 starcraft66 ]; |
|
Result of 1 package built:
Tested it. I play 1.16 and I don't see any regressions. |
bbjubjub2494
approved these changes
Jan 22, 2021
10 tasks
SuperSandro2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I encountered a serious issue preventing me from playing Minecraft version 1.12.2 due to missing GL libraries.
Things done
This PR fixes a few things regarding MultiMC.
Added libGL to libpath to fix launching old versions of Minecraft which previously caused a library error.
I also updated to the latest development build because MultiMC hasn't cut a release in years and the newest versions have support for important new features like running Feed The Beast packs released on their new launcher.
I also added myself to the maintainers of the package since I play Minecraft frequently and will push fixes if anything breaks.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)