Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnused/bzip2: add mic92 as maintainer #111489

Merged
merged 2 commits into from
Feb 1, 2021
Merged

gnused/bzip2: add mic92 as maintainer #111489

merged 2 commits into from
Feb 1, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 31, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title bzip2: add mic92 as maintainer gsed/bzip2: add mic92 as maintainer Jan 31, 2021
@Mic92 Mic92 changed the title gsed/bzip2: add mic92 as maintainer gnused/bzip2: add mic92 as maintainer Jan 31, 2021
@RaghavSood RaghavSood merged commit f23bfff into NixOS:master Feb 1, 2021
@Mic92 Mic92 deleted the maintainer branch February 1, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaghavSood RaghavSood RaghavSood approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mic92 @RaghavSood @SuperSandro2000