-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cc-wrapper: -nostdlib does not imply -nostdinc++ #111970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for including the C++ standard library headers was nested inside the check for linking with the C++ standard library. As a result, the `-nostdlib` flag incorrectly implied `-nostdinc++`, which made it virtually impossible to partially link C++ objects.
ofborg
bot
added
10.rebuild-darwin-stdenv
This PR causes stdenv to rebuild
10.rebuild-linux-stdenv
This PR causes stdenv to rebuild
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
labels
Feb 5, 2021
I think this broke Short reproduction (observed on x86_64-linux and x86_64-darwin):
|
veprbl
added a commit
to veprbl/nixpkgs
that referenced
this pull request
May 2, 2021
…ot its includes Should be the correct fix for NixOS#111970
10 tasks
jwiegley
pushed a commit
to jwiegley/nixpkgs
that referenced
this pull request
May 8, 2021
…ot its includes Should be the correct fix for NixOS#111970
jwiegley
pushed a commit
to jwiegley/nixpkgs
that referenced
this pull request
May 11, 2021
…ot its includes Should be the correct fix for NixOS#111970
jwiegley
pushed a commit
to jwiegley/nixpkgs
that referenced
this pull request
May 12, 2021
…ot its includes Should be the correct fix for NixOS#111970
jwiegley
pushed a commit
to jwiegley/nixpkgs
that referenced
this pull request
May 12, 2021
…ot its includes Should be the correct fix for NixOS#111970
jwiegley
pushed a commit
to jwiegley/nixpkgs
that referenced
this pull request
May 13, 2021
…ot its includes Should be the correct fix for NixOS#111970
jwiegley
pushed a commit
to jwiegley/nixpkgs
that referenced
this pull request
May 14, 2021
…ot its includes Should be the correct fix for NixOS#111970
jwiegley
pushed a commit
to jwiegley/nixpkgs
that referenced
this pull request
May 14, 2021
…ot its includes Should be the correct fix for NixOS#111970
jwiegley
pushed a commit
to jwiegley/nixpkgs
that referenced
this pull request
May 15, 2021
…ot its includes Should be the correct fix for NixOS#111970
jwiegley
pushed a commit
to jwiegley/nixpkgs
that referenced
this pull request
May 16, 2021
…ot its includes Should be the correct fix for NixOS#111970
jwiegley
pushed a commit
to jwiegley/nixpkgs
that referenced
this pull request
May 17, 2021
…ot its includes Should be the correct fix for NixOS#111970
rrbutani
added
the
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
label
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-darwin-stdenv
This PR causes stdenv to rebuild
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
10.rebuild-linux-stdenv
This PR causes stdenv to rebuild
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The check for including the C++ standard library headers was nested inside the
check for linking with the C++ standard library. As a result, the
-nostdlib
flag incorrectly implied
-nostdinc++
, which made it virtually impossible topartially link C++ objects.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)