Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.py-multicodec: init at 0.2.1 #112518

Merged
merged 1 commit into from
Feb 10, 2021
Merged

python3Packages.py-multicodec: init at 0.2.1 #112518

merged 1 commit into from
Feb 10, 2021

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Feb 9, 2021

Motivation for this change

This adds py-multicodec from https://github.com/multiformats/py-multicodec.
This is the first python package I'm adding to nixpkgs, so I welcome any improvement suggestions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 9, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 112518 at bc97ee0d run on x86_64-linux 1

3 packages built:

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 112518 at bc97ee0d run on aarch64-linux 1

3 packages built:

@SuperSandro2000 SuperSandro2000 merged commit d86ffe0 into NixOS:master Feb 10, 2021
@Luflosi Luflosi deleted the add-py-multicodec branch February 10, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luflosi @r-rmcgibbo @SuperSandro2000