Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

androidStudioPackages.{beta,canary,dev}: update #112665

Merged
merged 2 commits into from Feb 10, 2021
Merged

androidStudioPackages.{beta,canary,dev}: update #112665

merged 2 commits into from Feb 10, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 10, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Feb 10, 2021

Tested building and running an application on each version.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Feb 10, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 112665 at 7de86f2 run on x86_64-linux 1

3 packages built:
  • androidStudioPackages.beta
  • androidStudioPackages.canary
  • androidStudioPackages.dev

@SuperSandro2000 SuperSandro2000 merged commit b49e5d4 into NixOS:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-rmcgibbo @SuperSandro2000 @meutraa