Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcitx5: enable gtk4 #112670

Merged
merged 1 commit into from
Feb 11, 2021
Merged

fcitx5: enable gtk4 #112670

merged 1 commit into from
Feb 11, 2021

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Feb 10, 2021 •
edited
Loading

Motivation for this change

We have gtk4 in nixpkgs now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124
fcitx5: enable gtk4
2536d3c 
since we do have that in nixpkgs now
@ofborg ofborg bot requested a review from poscat0x04 February 10, 2021 18:58
@poscat0x04
Copy link
Contributor

thank you

@ajs124 ajs124 merged commit ff65ba7 into NixOS:master Feb 11, 2021
@ajs124 ajs124 deleted the fcitx5_gtk4 branch February 11, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poscat0x04 poscat0x04 poscat0x04 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajs124 @poscat0x04