Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uwsgi: fix cross-compilation #113242

Merged
merged 1 commit into from
Jul 14, 2021
Merged

uwsgi: fix cross-compilation #113242

merged 1 commit into from
Jul 14, 2021

Conversation

lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Feb 16, 2021

Motivation for this change

Allows uwsgi to be cross-compiled. I've built and tested the python3 plugin.

cc @abbradar @schneefux @globin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 113242 at 1e54261 run on aarch64-linux 1

1 package built:
7 suggestions:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/servers/uwsgi/default.nix:70:9:

       |
    70 |         ./no-ext-session-php_session.h-on-NixOS.patch
       |         ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/servers/uwsgi/default.nix:71:9:

       |
    71 |         ./additional-php-ldflags.patch
       |         ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/servers/uwsgi/default.nix:116:3:

        |
    116 |   buildPhase = ''
        |   ^
    
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/servers/uwsgi/default.nix:101:3:

        |
    101 |   configurePhase = ''
        |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/uwsgi/default.nix:122:3:

        |
    122 |   installPhase = ''
        |   ^
    
  • warning: unclear-gpl

    gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/servers/uwsgi/default.nix:130:5:

        |
    130 |     license = licenses.gpl2;
        |     ^
    
  • warning: unused-argument

    Unused argument: libmysqlclient.
    Near pkgs/servers/uwsgi/default.nix:8:14:

      |
    8 | , ruby, php, libmysqlclient
      |              ^
    

@lopsided98
Copy link
Contributor Author

lopsided98 commented Feb 16, 2021

@ofborg build pkgsCross.armv7l-hf-multiplatform.uwsgi

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 113242 at 1e54261 run on x86_64-linux 1

3 packages built:
7 suggestions:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/servers/uwsgi/default.nix:70:9:

       |
    70 |         ./no-ext-session-php_session.h-on-NixOS.patch
       |         ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/servers/uwsgi/default.nix:71:9:

       |
    71 |         ./additional-php-ldflags.patch
       |         ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/servers/uwsgi/default.nix:116:3:

        |
    116 |   buildPhase = ''
        |   ^
    
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/servers/uwsgi/default.nix:101:3:

        |
    101 |   configurePhase = ''
        |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/uwsgi/default.nix:122:3:

        |
    122 |   installPhase = ''
        |   ^
    
  • warning: unclear-gpl

    gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/servers/uwsgi/default.nix:130:5:

        |
    130 |     license = licenses.gpl2;
        |     ^
    
  • warning: unused-argument

    Unused argument: libmysqlclient.
    Near pkgs/servers/uwsgi/default.nix:8:14:

      |
    8 | , ruby, php, libmysqlclient
      |              ^
    

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM and cross compiles from amd64.

@siraben siraben added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Feb 18, 2021
@symphorien symphorien merged commit 05e46e3 into NixOS:master Jul 14, 2021
@lopsided98 lopsided98 deleted the uwsgi-cross branch July 14, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants