claws-mail{,-gtk3}: refactor and merge #113663
Conversation
Update Claws Mail to its latest version and perform a major refactoring. Previously, the configurable arguments were neither complete nor named according to the configure.ac file. Likewise, the values did not correspond to the defaults, but rather to a personal preference. This has now been changed to enable the arguments which are enabled in the configure.ac file. Also the variable names have been adjusted. For compatibility the old parameters also exist. Next to the claws-mail package is the "experimental" claws-mail-gtk3 package for the non official gtk3 git branch. This package started as an almost one-to-one copy of the claws-mail derivation which small modifications. This package was of course not updated. This has also been changed so that both packages are built from the same derivative.
also add myself as maintainer
ofborg
bot
added
11.by: package-maintainer
ajs124
changed the title
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages built:
claws-mail: Ask if output path lib (3.0M) could be split with outputs = [ ... "lib" ]; |
There was a problem hiding this comment.
Thank you very much for continuing this Pull Request, I really appreciate it!
I have successfully build both packages and tested them to some extent. Everything seems to work. However, I added one comment regarding the version of the GTK3 tag.
Feel free to leave me on the maintainer list if you like, as I still use Claws as my backup mail client. Thanks again!
| outputs = [ "out" "dev" ]; | ||
| # The corresponding commit in the gtk3 branch. | ||
| gtk3src = { | ||
| rev = "3.99.0"; |
There was a problem hiding this comment.
This one bugs me a little due to the fact that the special 3.99 tag is not the GTK3 equivalent of the 3.17.8 release. Furthermore, a tagged GTK3 version is new and, as far as I read the mailing list correctly, the 3.99.x (?) releases will be used until version 4.0 is ready.
So maybe the two packages should both use their git tag as versions, claws-mail with 3.17.8 and claws-mail-gtk3 with 3.99.0?
There was a problem hiding this comment.
I only chose that rev, because it's already on master since 2341270
Switching the version for -gtk3 is probably not a bad idea, yes.
It was inadvertently disabled by NixOS#113663.
It was inadvertently disabled by #113663.
Motivation for this change
This picks up where #100143 left off
@oxzi should I remove (or rather, not add) you from maintainers, while I'm at it, since you're not using claws anymore?
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)