Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackage shortuuid: init at 0.4.2 #11401

Merged
merged 1 commit into from
Jan 17, 2016
Merged

Conversation

zagy
Copy link
Contributor

@zagy zagy commented Dec 2, 2015

No description provided.

@domenkozar
Copy link
Member

hash mismatch in downloaded path ‘/nix/store/a45l8r0zqfr5jhqswqqcya28h59n63js-python2.7-setuptools-18.2’: expected 563b3d1b693c5579ef6f05544ff72fc30a26e13e506ee5265eea81081c331b6d, got 50db90fe916eca8cbba2f3a1a00dae35c4f3d40a25ff693487938bf38ae8ff3a

This is the same as you got @FRidh right?

@FRidh
Copy link
Member

FRidh commented Dec 2, 2015

Yes, exactly. #11320
It was odd, it happened I think twice after each other but after that I wasn't able to reproduce it.

@FRidh
Copy link
Member

FRidh commented Dec 2, 2015

also the exact same hashes, although vice versa

@zagy
Copy link
Contributor Author

zagy commented Dec 2, 2015

Oh boy. Could the CDN or some cache have a broken version? That's what the checksum are for after all.

@zagy
Copy link
Contributor Author

zagy commented Dec 4, 2015

Anything I can do here?


src = pkgs.fetchurl {
url = "https://pypi.python.org/packages/source/s/shortuuid/${name}.tar.gz";
md5 = "142e3ae4e7cd32d41a71deb359db4cfe";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use a sha256 instead? It's the preferred hash.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally yes. The md5 is the one which is published on pypi, making it trivial to add. So if it's not a huge problem, I'd stick with that.

@FRidh
Copy link
Member

FRidh commented Dec 5, 2015

Looks fine to me. Did you test whether it builds for all interpreters and versions?

@zagy
Copy link
Contributor Author

zagy commented Dec 5, 2015

I thought I did. But I'm not sure anymore. Will re-check.

@zagy
Copy link
Contributor Author

zagy commented Dec 5, 2015

Okay, now I did something with git which was probably wrong. :/
Will check on that later.

};


shortuuid = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why duplicating the package?

@zagy zagy force-pushed the add/shortuuid branch 4 times, most recently from a2841d8 to 9fa18b1 Compare December 7, 2015 06:24
@zagy
Copy link
Contributor Author

zagy commented Dec 7, 2015

better now?

@garbas
Copy link
Member

garbas commented Dec 7, 2015

@zagy still no :( check travis build or use nox locally to verify...

currently it looks like you're using isPy32 which was removed

@zagy
Copy link
Contributor Author

zagy commented Dec 8, 2015

On 07.12.2015, at 14:25, Rok Garbas notifications@github.com wrote:

@zagy still no :( check travis build or use nox locally to verify...

currently it looks like you're using isPy32 which was removed

Yeah, sorry. My workflow and knowledge aren't good enough, yet. Didn’t even know about nox. Will try that. Thanks for your patience.

Dipl. Inform. (FH) Christian Zagrodnick · cz@flyingcircus.io · +49 345 219401 0
Flying Circus Internet Operations GmbH · http://flyingcircus.io
Forsterstraße 29 · 06112 Halle (Saale) · Deutschland
HR Stendal HRB 21169 · Geschäftsführer: Christian Theune, Christian Zagrodnick

@vcunat
Copy link
Member

vcunat commented Dec 15, 2015

Ping.

@vcunat vcunat added the 8.has: package (new) This PR adds a new package label Dec 15, 2015
@zagy
Copy link
Contributor Author

zagy commented Dec 15, 2015

@vcunat Hi. Sorry for the late response. There was this state where master wasn't building (the bash thing) and I just couldn't get to the point of testing this reliably.

domenkozar added a commit that referenced this pull request Jan 17, 2016
pythonPackage shortuuid: init at 0.4.2
@domenkozar domenkozar merged commit f69743b into NixOS:master Jan 17, 2016
@domenkozar
Copy link
Member

@zagy I've merged this, but please use sha256 as we're trying to phase out md5 #4491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants