-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackage shortuuid: init at 0.4.2 #11401
Conversation
This is the same as you got @FRidh right? |
Yes, exactly. #11320 |
also the exact same hashes, although vice versa |
Oh boy. Could the CDN or some cache have a broken version? That's what the checksum are for after all. |
Anything I can do here? |
|
||
src = pkgs.fetchurl { | ||
url = "https://pypi.python.org/packages/source/s/shortuuid/${name}.tar.gz"; | ||
md5 = "142e3ae4e7cd32d41a71deb359db4cfe"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you use a sha256 instead? It's the preferred hash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally yes. The md5 is the one which is published on pypi, making it trivial to add. So if it's not a huge problem, I'd stick with that.
Looks fine to me. Did you test whether it builds for all interpreters and versions? |
I thought I did. But I'm not sure anymore. Will re-check. |
Okay, now I did something with git which was probably wrong. :/ |
}; | ||
|
||
|
||
shortuuid = buildPythonPackage rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why duplicating the package?
a2841d8
to
9fa18b1
Compare
better now? |
@zagy still no :( check travis build or use nox locally to verify... currently it looks like you're using isPy32 which was removed |
Yeah, sorry. My workflow and knowledge aren't good enough, yet. Didn’t even know about nox. Will try that. Thanks for your patience. Dipl. Inform. (FH) Christian Zagrodnick · cz@flyingcircus.io · +49 345 219401 0 |
Ping. |
@vcunat Hi. Sorry for the late response. There was this state where master wasn't building (the bash thing) and I just couldn't get to the point of testing this reliably. |
pythonPackage shortuuid: init at 0.4.2
No description provided.