-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-c-io: depend on Security.framework on darwin #114814
Conversation
This is needed on `aarch64-darwin` with newer SDK.
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 3 packages marked as broken and skipped:
6 packages failed to build and already failed to build on hydra master:
3 packages failed to build and are new build failures:
42 packages built:
The following issues got detected with the above build packages.
cachix:
warning: maintainers-missing Near pkgs/development/haskell-modules/generic-builder.nix:640:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: attribute-typo Near pkgs/development/compilers/crystal/build-package.nix:57:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: attribute-typo Near pkgs/development/tools/go2nix/default.nix:35:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md warning: maintainers-missing Near pkgs/development/haskell-modules/generic-builder.nix:640:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: build-tools-in-build-inputs Near pkgs/development/libraries/libnixxml/default.nix:14:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md warning: unclear-gpl Near pkgs/tools/package-management/nix-doc/default.nix:25:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unclear-gpl Near pkgs/tools/package-management/nix-du/default.nix:27:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: maintainers-missing Near pkgs/development/libraries/nix-plugins/default.nix:18:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: license-missing Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:22:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md warning: license-missing Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:22:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md warning: license-missing Near pkgs/build-support/docker/nix-prefetch-docker.nix:19:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md warning: license-missing Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:22:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md warning: license-missing Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:22:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md warning: license-missing Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:22:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md warning: unclear-gpl Near pkgs/tools/package-management/nix-serve/default.nix:42:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: attribute-typo Near pkgs/development/tools/vgo2nix/default.nix:26:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md |
I have confirmed that this is needed because aws-c-io currently can not be configured (without patching) to use OpenSSL on Darwin: it uses darwinssl from its Security library. |
Motivation for this change
This is needed on
aarch64-darwin
with newer SDK in #105026.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)