Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-c-io: depend on Security.framework on darwin #114814

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Mar 2, 2021

Motivation for this change

This is needed on aarch64-darwin with newer SDK in #105026.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS (aarch64)
    • other Linux distributions (aarch64)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This is needed on `aarch64-darwin` with newer SDK.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 2, 2021
@bobrik bobrik mentioned this pull request Mar 2, 2021
21 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Mar 2, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 114814 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • fusionInventory
  • nix-exec
  • nixui
6 packages failed to build and already failed to build on hydra master:
  • crystal2nix: log was empty
  • haskellPackages.hercules-ci-agent: plain log | pretty log
  • haskellPackages.update-nix-fetchgit: log was empty
  • hercules-ci-agent: plain log | pretty log
  • (nixUnstable): log was empty
  • update-nix-fetchgit: log was empty
3 packages failed to build and are new build failures:
42 packages built:
  • aws-c-event-stream
  • aws-c-io
  • aws-sdk-cpp
  • bundix
  • cabal2nix
  • cachix
  • crate2nix
  • dep2nix
  • go2nix
  • haskellPackages.cachix
  • haskellPackages.nix-paths
  • libnixxml
  • nix (nixStable)
  • nix-bundle
  • nix-direnv
  • nix-doc
  • nix-du
  • nix-index
  • nix-pin
  • nix-plugins
  • nix-prefetch-bzr
  • nix-prefetch-cvs
  • nix-prefetch-docker
  • nix-prefetch-git
  • nix-prefetch-hg
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-serve
  • nix-update-source
  • nixos-generators
  • nixos-shell
  • python37Packages.nix-kernel
  • python37Packages.nixpkgs
  • python37Packages.pythonix
  • python38Packages.nix-kernel
  • python38Packages.nixpkgs
  • python38Packages.pythonix
  • python39Packages.nix-kernel
  • python39Packages.nixpkgs
  • python39Packages.pythonix
  • vgo2nix
  • vulnix

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

cachix:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/haskell-modules/generic-builder.nix:640:3:

    |
640 |   meta = { inherit homepage license platforms; }
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

crystal2nix:

warning: attribute-typo
A likely typo in CRFLAGS argument was found, did you mean CFLAGS?

Near pkgs/development/compilers/crystal/build-package.nix:57:3:

   |
57 |   CRFLAGS = lib.concatStringsSep " " defaultOptions;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: unused-argument
Unused argument: fetchgit.
Near pkgs/development/compilers/crystal2nix/default.nix:1:25:

  |
1 | { lib, fetchFromGitHub, fetchgit, crystal, makeWrapper, nix-prefetch-git }:
  |                         ^
go2nix:

warning: attribute-typo
A likely typo in allowGoReference argument was found, did you mean allowedReferences?

Near pkgs/development/tools/go2nix/default.nix:35:3:

   |
35 |   allowGoReference = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md

haskellPackages.cachix:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/haskell-modules/generic-builder.nix:640:3:

    |
640 |   meta = { inherit homepage license platforms; }
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

libnixxml:

warning: build-tools-in-build-inputs
pkg-config is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/libraries/libnixxml/default.nix:14:3:

   |
14 |   buildInputs = [ pkg-config libxml2 gd.dev glib getopt libxslt nix ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: no-uri-literals
URI literals are deprecated.
Near pkgs/development/libraries/libnixxml/default.nix:22:16:

   |
22 |     homepage = https://github.com/svanderburg/libnixxml;
   |                ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-uri-literals.md

nix-doc:

warning: unclear-gpl
lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.

Near pkgs/tools/package-management/nix-doc/default.nix:25:5:

   |
25 |     license = licenses.lgpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

nix-du:

warning: unclear-gpl
lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.

Near pkgs/tools/package-management/nix-du/default.nix:27:5:

   |
27 |     license = licenses.lgpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

nix-plugins:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/libraries/nix-plugins/default.nix:18:3:

   |
18 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

nix-prefetch-bzr:

warning: license-missing
Package is missing a license

Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:22:5:

   |
22 |     meta = with lib; {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

nix-prefetch-cvs:

warning: license-missing
Package is missing a license

Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:22:5:

   |
22 |     meta = with lib; {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

nix-prefetch-docker:

warning: license-missing
Package is missing a license

Near pkgs/build-support/docker/nix-prefetch-docker.nix:19:3:

   |
19 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

nix-prefetch-git:

warning: license-missing
Package is missing a license

Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:22:5:

   |
22 |     meta = with lib; {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

nix-prefetch-hg:

warning: license-missing
Package is missing a license

Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:22:5:

   |
22 |     meta = with lib; {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

nix-prefetch-svn:

warning: license-missing
Package is missing a license

Near pkgs/tools/package-management/nix-prefetch-scripts/default.nix:22:5:

   |
22 |     meta = with lib; {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

nix-serve:

warning: unclear-gpl
lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.

Near pkgs/tools/package-management/nix-serve/default.nix:42:5:

   |
42 |     license = licenses.lgpl21;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

vgo2nix:

warning: attribute-typo
A likely typo in allowGoReference argument was found, did you mean allowedReferences?

Near pkgs/development/tools/vgo2nix/default.nix:26:3:

   |
26 |   allowGoReference = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md

@SuperSandro2000 SuperSandro2000 merged commit 075bdea into NixOS:master Mar 2, 2021
@orivej
Copy link
Contributor

orivej commented Mar 3, 2021

I have confirmed that this is needed because aws-c-io currently can not be configured (without patching) to use OpenSSL on Darwin: it uses darwinssl from its Security library.

@bobrik bobrik deleted the ivan/aws-c-io-security branch March 6, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants