Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cypress: from 6.0.0 to 6.5.0 #114889

Merged
merged 1 commit into from
Mar 3, 2021
Merged

cypress: from 6.0.0 to 6.5.0 #114889

merged 1 commit into from
Mar 3, 2021

Conversation

cideM
Copy link
Contributor

@cideM cideM commented Mar 2, 2021 •
edited
Loading

Motivation for this change

Screenshot from 2021-03-02 22-01-44

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from mmahut and thorstenweber83 March 2, 2021 21:10
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 2, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 114889 at bf6d8c3 run on x86_64-linux 1

1 package built:
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/web/cypress/default.nix:25:3:

       |
25 |   installPhase = ''
   |   ^

@SuperSandro2000 SuperSandro2000 merged commit 66cee0f into NixOS:master Mar 3, 2021
@cideM cideM deleted the update-cypress branch April 27, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@thorstenweber83 thorstenweber83 Awaiting requested review from thorstenweber83

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cideM @r-rmcgibbo @SuperSandro2000