gosmore: r30811 -> r31801, fix sha256 #11524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @abbradar, @domenkozar and @7c6f434c to be potential reviewers |
mcmtroffaes
force-pushed
the
feature/gosmore-fix-and-update
branch
from
d1eb4a2
to
b789856
Compare
cillianderoiste
added a commit
that referenced
this pull request
Dec 12, 2015
…date gosmore: r30811 -> r31801, fix sha256
|
Thanks for merging. In the mean time there were another few commits to the svn external so this derivation broke again. :-/ I'll look at a way of fixing this more permanently (e.g. specifying the externals and their revisions explicitly). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing another broken build (see https://hydra.nixos.org/build/28630074). I've also updated the svn revision. Successfully built and tested on nixpkgs-unstable and rebased onto master.
I have only very briefly tested the application itself, however the last revision to the core source code is r30327 so this update doesn't affect any of the code. The only difference for this project is in the "map-icons" external (currently at revision 31801), which as far as I can tell only contains data, so this should mostly keep working.
A wider issue is that svn does not lock externals at a specific revision if not properly set up - this being a limitation of subversion itself of course - so this project will keep breaking its hash on every commit to the external...
cc @7c6f434c (Michael Raskin) @domenkozar