fish: Use /bin/hostname on darwin. Fixes #11012. #11691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @samuelrivas, @bjornfor and @ocharles to be potential reviewers |
|
I don't have any real thoughts on this - it looks like it makes |
ocharles
added a commit
that referenced
this pull request
Dec 14, 2015
fish: Use /bin/hostname on darwin. Fixes #11012.
|
It comes from the cc @pikajude |
|
Ok, cool! Thanks! |
13 tasks
emhamm
added a commit
to emhamm/nixpkgs
that referenced
this pull request
Jan 20, 2023
prometheus 2.40.x is out of support since 12/2022 therefore the update to 2.41.0
between those two releases security critical patches have been added both to
prometheus codebase and upstream dependecies, see:
* 2.40.6 / 2022-12-09
prometheus/prometheus#11690
[SECURITY] Security upgrade from go and upstream dependencies that include
security fixes to the net/http and os packages. NixOS#11691
* 2.40.4 / 2022-11-29
GHSA-7rg2-cxvp-9p7p
GHSA-4v48-4q5m-8vx4
[SECURITY] Fix basic authentication bypass vulnerability
(CVE-2022-46146) GHSA-4v48-4q5m-8vx4
github-actions bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
prometheus 2.40.x is out of support since 12/2022 therefore the update to 2.41.0
between those two releases security critical patches have been added both to
prometheus codebase and upstream dependecies, see:
* 2.40.6 / 2022-12-09
prometheus/prometheus#11690
[SECURITY] Security upgrade from go and upstream dependencies that include
security fixes to the net/http and os packages. #11691
* 2.40.4 / 2022-11-29
GHSA-7rg2-cxvp-9p7p
GHSA-4v48-4q5m-8vx4
[SECURITY] Fix basic authentication bypass vulnerability
(CVE-2022-46146) GHSA-4v48-4q5m-8vx4
(cherry picked from commit bfac961)
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nettoolsare unavailable for Darwin and I don't know of the alternatives. So falling back to usinghostnamefrom the environment (as it was prior to #10841).If there's a nix package with
hostnamefor Darwin, please let me know, I'll fix this PR to use it instead.