Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager: 1.30.0 -> 1.30.2 #117030

Merged
merged 1 commit into from
Mar 21, 2021
Merged

networkmanager: 1.30.0 -> 1.30.2 #117030

merged 1 commit into from
Mar 21, 2021

Conversation

amaxine
Copy link
Contributor

@amaxine amaxine commented Mar 20, 2021

Motivation for this change

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/1.30.2/NEWS

===============================================
NetworkManager-1.30.2
Overview of changes since NetworkManager-1.30.0
===============================================

* Increase the limit of open file descriptors in NetworkManager.service
* Fix hostname lookup via DNS when resolv.conf is managed by
  systemd-resolved
* Enable WPA3 for Wi-Fi connections with key_mgmt=WPA-PSK
* Fix crash with the IWD Wi-Fi backend
* Avoid logging warning when setting bond option
  "ad_actor_system=00:00:00:00:00:00"
* Update SpecificObject D-Bus property of ActiveConnection after WiFi
  roaming
* Multiple bugfixes in the initrd generator
* Various minor bugfixes
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 117030 at 4b3c660 run on x86_64-linux 1

127 packages marked as broken and skipped:
  • gimpPlugins.exposureBlend
  • gimpPlugins.texturize
  • glimpsePlugins.exposureBlend
  • glimpsePlugins.texturize
  • gnome3.gnome-books
  • gnome3.gnome-documents
  • gnunet-gtk
  • libsForQt512.akonadi-calendar
  • libsForQt512.akonadiconsole
  • libsForQt512.alkimia
  • ...
527 packages skipped due to time constraints:
  • adapta-gtk-theme
  • almanah
  • apostrophe
  • appgate-sdp
  • arc-theme
  • areca
  • arx-libertatis
  • asciidoc-full
  • asciidoc-full-with-plugins
  • astroid
  • ...
2 packages built successfully:
1 suggestion:
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/tools/networking/networkmanager/default.nix:1:63:

      |
    1 | { lib, stdenv, fetchurl, substituteAll, intltool, pkg-config, fetchpatch, dbus
      |                                                               ^
    

@SuperSandro2000
Copy link
Member

When evaling with aliases disabled I get the following error:

error: --- EvalError ----------------------------------------------------------------------------------------------------------------------------------------------- nix-shellat: (284:9) in file: /home/hotpi/.cache/nixpkgs-review/pr-117030/shell.nix

   283|         xfce."xfce4-netload-plugin"
   284|         xfce."xfce4notifyd"
      |         ^
   285|         xfce."xfce4panel"

attribute 'xfce4notifyd' missing
(use '--show-trace' to show detailed location information)

which is most likely unrelated.

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Mar 20, 2021
@jtojnar jtojnar merged commit 8a83999 into NixOS:staging Mar 21, 2021
@amaxine amaxine deleted the NetworkManager-1.30.2 branch July 19, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants