Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdf2svg: 0.2.2 -> 0.2.3 #11822

Merged
merged 1 commit into from
Dec 19, 2015
Merged

pdf2svg: 0.2.2 -> 0.2.3 #11822

merged 1 commit into from
Dec 19, 2015

Conversation

rycee
Copy link
Member

@rycee rycee commented Dec 19, 2015

Also minor style changes and upstream source is now on GitHub.

Also minor style changes and upstream source is now on GitHub.
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @wavewave, @spwhitt and @domenkozar to be potential reviewers

jagajaga added a commit that referenced this pull request Dec 19, 2015
@jagajaga jagajaga merged commit 4472df4 into NixOS:master Dec 19, 2015
@rycee rycee deleted the bump/pdf2svg branch December 19, 2015 20:22
@vcunat
Copy link
Member

vcunat commented Dec 22, 2015

Strange. On i686-linux it seems to require autotools http://hydra.nixos.org/build/29214063/nixlog/1/raw but x86_64-linux is fine.

@rycee
Copy link
Member Author

rycee commented Dec 22, 2015

@vcunat, that is quite strange. I played around with it and it seems related to the file timestamps. In particular if I do a touch aclocal.m4 configure Makefile.in in a nix-shell -a pdf2svg it builds just fine while it fails otherwise (on i686, for whatever reason it builds fine regardless on x86_64).

I created PR #11888 to fix the build. In the PR I simply added autoreconfHook as a dependency to force a regeneration of the autotool files.

By the way, thanks for the notice! I had indeed only tested this package on x86_64. I did not predict this interesting issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants