Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

myxer: init at 1.2.0 #118839

Merged
merged 2 commits into from
Apr 19, 2021
Merged

myxer: init at 1.2.0 #118839

merged 2 commits into from
Apr 19, 2021

Conversation

ErinvanderVeen
Copy link
Member

@ErinvanderVeen ErinvanderVeen commented Apr 8, 2021 •
edited
Loading

Motivation for this change

Myxer (a good alternative to pavucontrol) was missing from nixpkgs. This PR contains 2 commits as Myxer was updated to 1.2.0 after this PR was made. The first commits inits at 1.1.3, the second updates to 1.2.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 8, 2021
SuperSandro2000
SuperSandro2000 requested changes Apr 8, 2021
View reviewed changes
pkgs/applications/audio/myxer/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/myxer/default.nix Outdated Show resolved Hide resolved
@ErinvanderVeen
Copy link
Member Author

Myxer 1.2.0 was released a few hours ago. I think it's best to add the update to 1.2.0 to this MR so I'll put it on draft until I have upgraded it.

@ErinvanderVeen ErinvanderVeen marked this pull request as draft April 9, 2021 05:49
@ErinvanderVeen ErinvanderVeen changed the title myxer: init at 1.1.3 myxer: init at 1.2.0 Apr 9, 2021
@ErinvanderVeen
Copy link
Member Author

I have updated the PR to include the update to 1.2.0 and updated the title of the PR to reflect this change.

@ErinvanderVeen ErinvanderVeen marked this pull request as ready for review April 9, 2021 06:01
@ErinvanderVeen
Copy link
Member Author

@SuperSandro2000 Could I kindly request you take another look at this MR? I have incorporated all your suggestions.

@SuperSandro2000 SuperSandro2000 merged commit 0db38ea into NixOS:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErinvanderVeen @SuperSandro2000