ricochet: init at 1.1.1 #11979
ricochet: init at 1.1.1 #11979
Conversation
|
/cc @ttuegel as I don't have much experience with the Qt infrastructure and would appreciate a code review. |
| export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE $(pkg-config --cflags openssl)" | ||
| ''; | ||
|
|
||
| configurePhase = '' |
There was a problem hiding this comment.
Instead of setting configurePhase, I would recommend doing this instead:
configureScript = "qmake";
dontAddPrefix = true;
configureFlags = [ "PREFIX=$(out)" "DEFINES+=RICOCHET_NO_PORTABLE" ];
This way, you don't need to worry about invoking the preConfigure hook. Setting the PREFIX should also make it the mkdir ...; cp ... steps in installPhase unnecessary, but you should double-check that by building it yourself because every QMake project is a little different.
There was a problem hiding this comment.
Thanks! This works fine. However, the mkdir ...; cp... steps still seem to be necessary as the ricochet binary is in the root directory of the project.
|
I have tested it and can confirm it works. Only thing that would be nice is a .desktop file. |
|
One thing I've noticed is that the memory usage of this thing is insane. I'm getting 340 MB right after startup, almost 500MB after some usage. Is this normal? |
Please DO NOT MERGE until #11974 has been merged as this PR depends on my entry in maintainers.nix that comes with #11974.
That being said, ricochet does seem to work fine.