Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swaylock-effects: 1.6-2 -> 1.6-3 #119869

Merged
merged 2 commits into from
Apr 19, 2021
Merged

swaylock-effects: 1.6-2 -> 1.6-3 #119869

merged 2 commits into from
Apr 19, 2021

Conversation

ymatsiuk
Copy link
Contributor

@ymatsiuk ymatsiuk commented Apr 19, 2021 •
edited
Loading

Motivation for this change

minor version bump + fmt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ymatsiuk ymatsiuk requested a review from bbigras April 19, 2021 13:09
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 19, 2021
@bbigras
Copy link
Contributor

bbigras commented Apr 19, 2021

Result of nixpkgs-review pr 119869 run on x86_64-linux 1

1 package built:
  • swaylock-effects

@ymatsiuk @SuperSandro2000
Apply suggestions from code review
e218eae 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@Ma27 Ma27 merged commit 92f5c75 into NixOS:master Apr 19, 2021
Ma27 pushed a commit that referenced this pull request Apr 19, 2021
@ymatsiuk @Ma27
swaylock-effects: 1.6-2 -> 1.6-3 (#119869)
7c23e16 
* swaylock-effects: 1.6-2 -> 1.6-3

* Apply suggestions from code review

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

Co-authored-by: Yurii Matsiuk <ymatsiuk@users.noreply.github.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
(cherry picked from commit 92f5c75)
@Ma27
Copy link
Member

Ma27 commented Apr 19, 2021

@ymatsiuk thanks!

Decided to backport this (7c23e16) and the previous bump (e3307d2) to 20.09. Both seem to have relevant bugfixes and no breaking changes.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Apr 19, 2021
@ymatsiuk ymatsiuk deleted the swaylock-effects branch May 19, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbigras bbigras Awaiting requested review from bbigras

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ymatsiuk @bbigras @Ma27 @SuperSandro2000