Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ejabberd: 20.12 -> 21.04 #122569

Merged
merged 3 commits into from
Jul 1, 2021
Merged

ejabberd: 20.12 -> 21.04 #122569

merged 3 commits into from
Jul 1, 2021

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented May 11, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 11, 2021

Result of nixpkgs-review pr 122569 at f04448c run on x86_64-linux 1

1 package built successfully:
  • ejabberd
1 suggestion:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/servers/xmpp/ejabberd/default.nix:115:5:

        |
    115 |     license = licenses.gpl2;
        |     ^
    

Result of nixpkgs-review pr 122569 at f04448c run on aarch64-linux 1

1 package built successfully:
  • ejabberd

@ajs124 ajs124 requested a review from Mic92 May 11, 2021 17:34
@hrhino
Copy link
Contributor

hrhino commented Jun 25, 2021

It appears that the license for this should be gpl2Plus according to the files' license headers; oddly, though, there are a few (such as src/mod_mqtt_ws.erl) that claim to be apache v2...

@hrhino
Copy link
Contributor

hrhino commented Jun 25, 2021

[nix-shell:~/.cache/nixpkgs-review/pr-122569]$ results/ejabberd/bin/iex
/nix/store/a94napnlmxxvlsvycqf0ynnd6w0igrbq-ejabberd-21.04/bin/elixir: line 126: exec: erl: not found

I'm getting this if I try to run iex or mix binaries... presumably those scripts should have their ERL_EXEC="erl" lines patched.

Copy link
Contributor

@hrhino hrhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comments

@Mic92 Mic92 merged commit 9b24799 into NixOS:master Jul 1, 2021
@Izorkin Izorkin deleted the update-ejabberd branch July 4, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants