-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tweepy and chardet Python modules #12286
Conversation
|
||
src = pkgs.fetchurl { | ||
url = "http://pypi.python.org/packages/source/c/chardet/${name}.tar.gz"; | ||
md5 = "295367fd210d20f3febda615a88e1ef0"; | ||
md5 = "25274d664ccb5130adae08047416e1a8"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use sha256
when bumping packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used md5
because somewhere it was mentioned that we use hashes from pypi
when available -- so do I understand correctly that we prefer sha256
generated by ourselves after all? (I myself do like using sha256
more)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we want to deprecate md5. If you remember where you heard about md5, let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly no, was a long time ago. Good to know, fixed and added a mention to the top of python-packages.nix
for others.
Hm, EDIT: I'll ask the one who needed the package update if |
If different versions are required then we include different versions. You can update |
New Tweepy has Python 3 support. I remember I've updated
chardet
becase some script required newer version of it, but sadly I can't remember details (it was quite some time ago).