Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tweepy and chardet Python modules #12286

Closed
wants to merge 3 commits into from
Closed

Conversation

abbradar
Copy link
Member

New Tweepy has Python 3 support. I remember I've updated chardet becase some script required newer version of it, but sadly I can't remember details (it was quite some time ago).

@abbradar abbradar added 9.needs: package (update) This needs a package to be updated 8.has: package (update) This PR updates a package to a newer version 8.has: module (update) This PR changes an existing module in `nixos/` and removed 9.needs: package (update) This needs a package to be updated 8.has: package (update) This PR updates a package to a newer version labels Jan 10, 2016
@domenkozar domenkozar added 6.topic: python and removed 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 10, 2016

src = pkgs.fetchurl {
url = "http://pypi.python.org/packages/source/c/chardet/${name}.tar.gz";
md5 = "295367fd210d20f3febda615a88e1ef0";
md5 = "25274d664ccb5130adae08047416e1a8";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use sha256 when bumping packages

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used md5 because somewhere it was mentioned that we use hashes from pypi when available -- so do I understand correctly that we prefer sha256 generated by ourselves after all? (I myself do like using sha256 more)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we want to deprecate md5. If you remember where you heard about md5, let me know.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly no, was a long time ago. Good to know, fixed and added a mention to the top of python-packages.nix for others.

@domenkozar
Copy link
Member

@abbradar
Copy link
Member Author

Hm, turses requires tweepy == 3.3.0 (and as seen on their GitHub 1 it really wants 3.1.0). What do we do in those cases?

EDIT: I'll ask the one who needed the package update if tweepy 3.1.0 would suffice,

@FRidh
Copy link
Member

FRidh commented Jan 14, 2016

If different versions are required then we include different versions. You can update tweepy to the latest version and have tweepy_0_3 = tweepy.override for turses.
cc @garbas for turses.

@garbas garbas closed this in f75a122 Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants