Eclipse modular #12428
Merged
Eclipse modular #12428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @edolstra, @MarcWeber and @rycee to be potential reviewers |
|
Thanks, really nice! I was thinking about picking this up myself but haven't had the time recently. I'm intending to do some work to allow simultaneous installation of several Eclipses (e.g., having both Scala-IDE and vanilla Eclipse installed at the same time) and would like to base that work on these improvements. |
|
I will merge that soon if nobody comments. Should I squash to get 1 commit? |
|
I'm OK with either squashed or non-squashed. If you prefer to squash then I'd suggest adding a "Suggested-by: muradu" line to the commit message to add credit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue the work started in #10852 by @muradu as he does not seem to take care of the comments there.