Renamed subdirectories in Android SKD's build-tools #12447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nix unzips the different components of the Android SDK one by one. It followed the directory structure of complete packages released for mainstream OS but the names of the directories in build-tools doesn't match those. As a result, some programs assuming the usual directory structure and naming conventions broke (in my case it is a gradle plugin). This is a fix. It may introduce a regression if some programs rely on the current behavior.
|
By analyzing the blame information on this pull request, we identified @MP2E, @svanderburg and @taku0 to be potential reviewers |
|
If it's what upstream uses, we should too. And Travis says nothing breaks, so... thanks! Don't see any maintainers; merging. |
nckx
added a commit
that referenced
this pull request
Jan 18, 2016
Renamed subdirectories in Android SKD's build-tools
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nix unzips the different components of the Android SDK one by one.
It followed the directory structure of complete packages released for
mainstream OS but the names of the directories in build-tools doesn't
match those.
As a result, some programs assuming the usual directory structure and
naming conventions broke (in my case it is a gradle plugin).
This is a fix. It may introduce a regression if some programs rely on
the current behavior.