Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ati-drivers: Restore opengl & direct rendering #12508

Merged
merged 1 commit into from
Jan 23, 2016
Merged

ati-drivers: Restore opengl & direct rendering #12508

merged 1 commit into from
Jan 23, 2016

Conversation

heydojo
Copy link
Contributor

@heydojo heydojo commented Jan 20, 2016

  • Removed a collision in the nix store
  • Removed dependency on qt
  • Fixed opengl and direct rendering by correcting some link paths
  • Some code refactored in builder.sh
  • Comments added/modified

This pull request fixes #11740,#11817 and I recommend that it be considered
as a hotfix for the stable channel due to the fact that opengl
and direct rendering are broken there too.

- Removed a collision in the nix store
- Removed dependency on qt
- Fixed opengl and direct rendering by correcting some link paths
- Some code refactored in builder.sh
- Comments added/modified

This pull request fixes #11740 and I recommend that it be considered
as a hotfix for the stable channel due to the fact that opengl
and direct rendering are broken there too.
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @MarcWeber, @nathanielbaxter and @offlinehacker to be potential reviewers

@vcunat vcunat added 0.kind: bug Something is broken 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Jan 20, 2016
@abbradar
Copy link
Member

Given that reportedly it doesn't work at all now and the patch looks good to me, I'll merge this in a few days if nobody would object.

@puffnfresh
Copy link
Member

@abbradar I just applied this patch locally and it seems to be working well, thank you!

@heydojo
Copy link
Contributor Author

heydojo commented Jan 23, 2016

I probably forgot to mention that the patch also fixes a bug with sddm (related to qt 5 opengl) where you get a white screen due to opengl not functioning. And the up shot of it is that with this patch; users of ati-drivers should now be able to pull Plasma 5 into their environment, set sddm as the default dm and migrate to Plasma Workspaces 5 if they so choose.

abbradar added a commit that referenced this pull request Jan 23, 2016
ati-drivers: Restore opengl & direct rendering
@abbradar abbradar merged commit 34769a3 into NixOS:master Jan 23, 2016
@heydojo
Copy link
Contributor Author

heydojo commented Jan 23, 2016

Yay! Thanks!
Ping me if it breaks or anyone finds something else not working.

@abbradar
Copy link
Member

No problem, thank you for your work ^_^

@heydojo heydojo deleted the ati-drivers-backport branch January 23, 2016 09:05
@abbradar
Copy link
Member

Do I understand correctly that release-15.09 has broken drivers, too?

@heydojo
Copy link
Contributor Author

heydojo commented Jan 23, 2016

@abbradar Yes. That is correct.

abbradar pushed a commit that referenced this pull request Jan 23, 2016
Pull request #12508. Fixes ATI unfree drivers; I cannot test this myself, but
reportedly they don't work at all now (#11817), so this can't make things worse.

- Removed a collision in the nix store
- Removed dependency on qt
- Fixed opengl and direct rendering by correcting some link paths
- Some code refactored in builder.sh
- Comments added/modified

This pull request fixes #11740 and I recommend that it be considered
as a hotfix for the stable channel due to the fact that opengl
and direct rendering are broken there too.

(cherry picked from commit 722c616)
@abbradar
Copy link
Member

Cherry-picked to 15.09 at a736968

@ocharles
Copy link
Contributor

Looking forward to giving this a try, sorry I haven't been able to test anything for a few days! Fingers crossed it still works :)

adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
Pull request NixOS#12508. Fixes ATI unfree drivers; I cannot test this myself, but
reportedly they don't work at all now (NixOS#11817), so this can't make things worse.

- Removed a collision in the nix store
- Removed dependency on qt
- Fixed opengl and direct rendering by correcting some link paths
- Some code refactored in builder.sh
- Comments added/modified

This pull request fixes NixOS#11740 and I recommend that it be considered
as a hotfix for the stable channel due to the fact that opengl
and direct rendering are broken there too.

(cherry picked from commit 722c616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to open fglrx_dri.so
6 participants