fix broken perl build due to impurity and glibc-locales build with arbitrary nix store path #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This probably solves problems on some platforms that expose /usr and /lib during build, see NixOS#386.
previously, $TMPDIR/nix/store is hard-coded so that only building and installing is correct with /nix/store
|
This changes |
vcunat
pushed a commit
that referenced
this pull request
Nov 25, 2013
previously, $TMPDIR/nix/store is hard-coded so that only building and installing is correct with /nix/store See #1273.
|
The first patch does, and it has been in stdenv-updates for about 8 months :-) There are many good things in there and it seems to finally stabilize... I'm hopeful we can truly merge it within several weeks. I push the second one to master, after verifying it builds and doesn't change stdenv. |
|
I took the liberty to amend the description a little. |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl build has an impurity (Issue #386), this fix resolves it.
Also, if I build glibc-locales with non standard nix store location, the build is not successful due to a bug in locales.nix. This is a fix.