Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pufferpanel: init at 2.2.0 #128243

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Conversation

ckiee
Copy link
Member

@ckiee ckiee commented Jun 26, 2021

Motivation for this change

Friend wanted PufferPanel packaged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ckiee
Copy link
Member Author

ckiee commented Jun 26, 2021

Result of nixpkgs-review pr 128243 run on x86_64-linux 1

1 package built:
  • pufferpanel

@r-rmcgibbo
Copy link

r-rmcgibbo commented Jun 26, 2021

Result of nixpkgs-review pr 128243 at 7ee44ca4 run on aarch64-linux 1

1 package built successfully:
  • pufferpanel
3 suggestions:
  • warning: unused-argument

    Unused argument: stdenv.
    Near pkgs/servers/pufferpanel/default.nix:7:3:

      |
    7 | , stdenv
      |   ^
    
  • warning: unused-argument

    Unused argument: pkgs.
    Near pkgs/servers/pufferpanel/default.nix:6:3:

      |
    6 | , pkgs
      |   ^
    
  • warning: unused-argument

    Unused argument: nodejs.
    Near pkgs/servers/pufferpanel/default.nix:5:3:

      |
    5 | , nodejs
      |   ^
    

Result of nixpkgs-review pr 128243 at 7ee44ca4 run on x86_64-linux 1

1 package built successfully:
  • pufferpanel
3 suggestions:
  • warning: unused-argument

    Unused argument: pkgs.
    Near pkgs/servers/pufferpanel/default.nix:6:3:

      |
    6 | , pkgs
      |   ^
    
  • warning: unused-argument

    Unused argument: nodejs.
    Near pkgs/servers/pufferpanel/default.nix:5:3:

      |
    5 | , nodejs
      |   ^
    
  • warning: unused-argument

    Unused argument: stdenv.
    Near pkgs/servers/pufferpanel/default.nix:7:3:

      |
    7 | , stdenv
      |   ^
    

@ckiee ckiee marked this pull request as draft June 27, 2021 15:49
@ckiee
Copy link
Member Author

ckiee commented Jun 27, 2021

Just discovered it requires java to be in the PATH alongside other things, marking as draft for now.

@ckiee ckiee marked this pull request as ready for review June 30, 2021 00:42
@ckiee
Copy link
Member Author

ckiee commented Jun 30, 2021

Further investigation revealed the required binaries change at runtime (and it's not feasible to include every single possible dependency) so this package so I've adapted the package for something like:

pkgs.pufferpanel.override {
    pathDeps = [ pkgs.openjdk16 ];
}

Oh also, thanks for the review as usual Sandro (:

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit b2be8c5 into NixOS:master Jul 1, 2021
@tie tie mentioned this pull request Jun 6, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants