Init bsnes hd

[gridbugs]

Motivation for this change

Adds the Super Nintendo (Super Famicon) emulator bsnes, specifically the bsnes-hd fork which adds some additional video features.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Relase notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 130166 at c002f3c8 run on x86_64-linux 1

1 package built successfully:

• bsnes-hd

5 suggestions:

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/misc/emulators/bsnes-hd/default.nix:43:3:

     |
  43 |   installPhase = ''
     |   ^
  

• warning: unclear-gpl

  gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

  Near pkgs/misc/emulators/bsnes-hd/default.nix:50:5:

     |
  50 |     license = licenses.gpl3;
     |     ^
  

• warning: missing-patch-comment

  Consider adding a comment explaining the purpose of this patch on the line preceeding.
  Near pkgs/misc/emulators/bsnes-hd/default.nix:26:34:

     |
  26 |   ++ optionals stdenv.isDarwin [ ./macos-replace-sips-with-png2icns.patch
     |                                  ^
  

• warning: missing-patch-comment

  Consider adding a comment explaining the purpose of this patch on the line preceeding.
  Near pkgs/misc/emulators/bsnes-hd/default.nix:27:34:

     |
  27 |                                  ./macos-copy-app-to-prefix.patch ];
     |                                  ^
  

• warning: missing-phase-hooks

  buildPhase should probably contain runHook preBuild and runHook postBuild.

  Near pkgs/misc/emulators/bsnes-hd/default.nix:39:3:

     |
  39 |   buildPhase = ''
     |   ^
  

[gridbugs]

Thanks for the review @SuperSandro2000! I committed all your suggested changes and replaced the installPhase and buildPhase sections with makeFlags and enableParallelBuilding and squashed the result into a single commit. I've confirmed that patching the macos part of the makefile doesn't affect the build on linux and I've retested building/running on macos and linux.