Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deadbeef-statusnotifier-plugin: init at 1.6 #130534

Merged
merged 2 commits into from
Jul 23, 2021
Merged

deadbeef-statusnotifier-plugin: init at 1.6 #130534

merged 2 commits into from
Jul 23, 2021

Conversation

kurnevsky
Copy link
Member

Motivation for this change

StatusNotifier icon plugin for deadbeef. By default it supports only xembed icons.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@kurnevsky kurnevsky mentioned this pull request Jul 23, 2021
Closed
SuperSandro2000
SuperSandro2000 requested changes Jul 23, 2021
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/audio/deadbeef/plugins/statusnotifier.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/deadbeef/plugins/statusnotifier.nix Outdated
Comment on lines 18 to 23
postPatch = [''
substituteInPlace tools/glib-mkenums \
--replace /usr/bin/perl "${perl}/bin/perl"
''];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
postPatch = [''
substituteInPlace tools/glib-mkenums \
--replace /usr/bin/perl "${perl}/bin/perl"
''];
postPatch = ''
substituteInPlace tools/glib-mkenums \
--replace /usr/bin/perl "${perl}/bin/perl"
'';

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

pkgs/applications/audio/deadbeef/plugins/statusnotifier.nix Outdated Show resolved Hide resolved
@kurnevsky kurnevsky force-pushed the deadbeef-statusnotifier-plugin branch 5 times, most recently from 7eaf618 to 30568a6 Compare July 23, 2021 10:02
@kurnevsky kurnevsky force-pushed the deadbeef-statusnotifier-plugin branch from 30568a6 to 61742fb Compare July 23, 2021 10:04
@SuperSandro2000 SuperSandro2000 merged commit 10e8eba into NixOS:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurnevsky @SuperSandro2000