Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs/agda2-mode: deprecate phases #133523

Merged
merged 1 commit into from
Aug 17, 2021
Merged

emacs/agda2-mode: deprecate phases #133523

merged 1 commit into from
Aug 17, 2021

Conversation

Stunkymonkey
Copy link
Contributor

Motivation for this change

compilation will be tested

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Stunkymonkey Stunkymonkey marked this pull request as draft August 11, 2021 16:35
@Stunkymonkey Stunkymonkey marked this pull request as ready for review August 15, 2021 12:00
veprbl
veprbl requested changes Aug 16, 2021
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

building '/nix/store/pm1kl14bbfamy7n66bv34mxpq3b5ly63-emacs-agda-mode-2.6.2.drv'...
unpacking sources
variable $src or $srcs should point to the source

@Stunkymonkey
Copy link
Contributor Author

could you please tell me how you tested this. I thought i tried it, but maybe I used the compiled version for the cache.

@veprbl
Copy link
Member

veprbl commented Aug 16, 2021

@GrahamcOfBorg emacsPackages.agda2-mode

@veprbl
Copy link
Member

veprbl commented Aug 16, 2021

@GrahamcOfBorg build emacsPackages.agda2-mode

@veprbl veprbl merged commit 7f972a2 into NixOS:master Aug 17, 2021
@Stunkymonkey Stunkymonkey deleted the agda2-mode-phases branch February 14, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@veprbl veprbl Awaiting requested review from veprbl

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stunkymonkey @veprbl