Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio: 1.1.36 → 1.1.37 #133877

Merged
merged 1 commit into from
Aug 16, 2021
Merged

factorio: 1.1.36 → 1.1.37 #133877

merged 1 commit into from
Aug 16, 2021

Conversation

nbraud
Copy link
Contributor

@nbraud nbraud commented Aug 14, 2021 •
edited
Loading

Motivation for this change

Users on 1.1.36 cannot play on 1.1.37 servers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nbraud
Copy link
Contributor Author

nbraud commented Aug 16, 2021

pokes @lukegb.

@lukegb lukegb merged commit c6dc09c into NixOS:master Aug 16, 2021
@lukegb
Copy link
Contributor

lukegb commented Aug 16, 2021

Thanks! Didn't see this :)

@nbraud nbraud deleted the factorio/1.1.37 branch August 16, 2021 21:38
@nbraud
Copy link
Contributor Author

nbraud commented Aug 16, 2021

No problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbraud @lukegb