Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skrooge: 2.24.6 ->2.26.1 #134048

Merged
merged 2 commits into from
Aug 15, 2021
Merged

skrooge: 2.24.6 ->2.26.1 #134048

merged 2 commits into from
Aug 15, 2021

Conversation

pasqui23
Copy link
Contributor

@pasqui23 pasqui23 commented Aug 14, 2021 •
edited
Loading

Motivation for this change

Latest skrooge versions moved to qtwebkit and allowed woob 3.0 integration

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jokogr August 14, 2021 16:30
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 14, 2021
@SuperSandro2000 SuperSandro2000 merged commit 69e4da7 into NixOS:master Aug 15, 2021
@pasqui23 pasqui23 deleted the skrooge branch August 15, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jokogr jokogr Awaiting requested review from jokogr

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pasqui23 @SuperSandro2000