Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lucenepp: 3.0.7 -> 3.0.8 #134481

Merged
merged 2 commits into from
Nov 12, 2021
Merged

lucenepp: 3.0.7 -> 3.0.8 #134481

merged 2 commits into from
Nov 12, 2021

Conversation

nagy
Copy link
Member

@nagy nagy commented Aug 17, 2021

Motivation for this change

The motivation is mostly to get rid of boost155 eventually.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 17, 2021

Result of nixpkgs-review pr 134481 at 6c0d2861 run on x86_64-linux 1

1 package failed to build:
1 package built successfully:
  • lucenepp
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/lucene++/default.nix:27:3:

       |
    27 |   meta = {
       |   ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 134481 at 6c0d2861 run on aarch64-linux 1

2 packages failed to build:

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@davidak
Copy link
Member

davidak commented Aug 19, 2021

@nagy could anything be done to fix build on aarch64-linux or should it be disabled?

@nagy
Copy link
Member Author

nagy commented Aug 19, 2021

It looks like it is just the test phase. Maybe we can skip the tests on aarch64-linux. I am still working on the poedit fails.

@nagy nagy marked this pull request as draft August 19, 2021 07:43
@nagy
Copy link
Member Author

nagy commented Aug 22, 2021

I could fix the poedit build failures. Lets see if the aarch64-linux tests still fail.

@ofborg ofborg bot requested a review from dasj19 August 22, 2021 21:50
@dasj19 dasj19 removed their request for review August 23, 2021 07:50
@nagy nagy marked this pull request as ready for review August 23, 2021 08:37
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 134481 run on x86_64-linux 1

2 packages built:
  • lucenepp
  • poedit

@SuperSandro2000 SuperSandro2000 merged commit fa6b4a9 into NixOS:master Nov 12, 2021
@ofborg ofborg bot requested a review from dasj19 November 12, 2021 17:22
@nagy nagy deleted the lucenepp branch November 12, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants