Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cnping: init at 2021-04-04 #135026

Merged
merged 2 commits into from
Nov 15, 2021
Merged

cnping: init at 2021-04-04 #135026

merged 2 commits into from
Nov 15, 2021

Conversation

ckiee
Copy link
Member

@ckiee ckiee commented Aug 21, 2021 •
edited
Loading

Motivation for this change

My ISP is playing games with me, so I'm doing the same back: ckiee/nixfiles@36b054a and I need this to monitor how well it's working.

Depends on #131526 for maintainer name change so it won't build until that's in master.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

I didn't add a release note since this is tiny and nix segfaulted when I tried to build a VM to test the setcap wrapper.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 21, 2021
@ckiee ckiee changed the title Cnping cnping: init at 2021-04-04 Aug 21, 2021
@ckiee ckiee force-pushed the cnping branch 2 times, most recently from e162679 to b971465 Compare October 14, 2021 14:19
@lukegb lukegb self-assigned this Oct 14, 2021
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Oct 14, 2021
@lukegb
Copy link
Contributor

lukegb commented Oct 14, 2021

Tested running cnping, seems to work. Didn't the module, but it also seems reasonable.

@ckiee ckiee requested a review from lukegb October 14, 2021 18:29
SuperSandro2000
SuperSandro2000 reviewed Nov 15, 2021
View reviewed changes
pkgs/tools/networking/cnping/default.nix
installPhase = ''
mkdir -p $out/{bin,share/man/man1}
cp cnping $out/bin/cnping
cp cnping.1 $out/share/man/man1/cnping.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use installManPage.

@SuperSandro2000 SuperSandro2000 merged commit 6f0ff67 into NixOS:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@lukegb lukegb Awaiting requested review from lukegb

Assignees

@lukegb lukegb

Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ckiee @lukegb @davidak @SuperSandro2000