Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: buildFlagsArray -> ldflags #135041

Merged
merged 18 commits into from
Aug 21, 2021
Merged

treewide: buildFlagsArray -> ldflags #135041

merged 18 commits into from
Aug 21, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 21, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 21, 2021

Result of nixpkgs-review pr 135041 at c299542 run on aarch64-linux 1

19 packages built successfully:
  • assh
  • dgoss
  • dockle
  • drone-cli
  • envdir
  • gitleaks
  • golangci-lint
  • goss
  • grype
  • kiterunner
  • kube3d
  • noti
  • safe
  • starboard
  • starboard-octant-plugin
  • telegraf
  • teler
  • ticker
  • trivy
1 suggestion:
  • warning: license-missing

    Package is missing a license.

    Near pkgs/development/go-packages/generic/default.nix:253:5:

        |
    253 |     meta = {
        |     ^
    

Result of nixpkgs-review pr 135041 at c299542 run on x86_64-linux 1

20 packages built successfully:
  • assh
  • dgoss
  • dockle
  • drone-cli
  • envdir
  • gitleaks
  • golangci-lint
  • goss
  • grype
  • kiterunner
  • kube3d
  • noti
  • safe
  • starboard
  • starboard-octant-plugin
  • telegraf
  • teler
  • ticker
  • trivy
  • vimPlugins.vim-go
1 suggestion:
  • warning: license-missing

    Package is missing a license.

    Near pkgs/development/go-packages/generic/default.nix:253:5:

        |
    253 |     meta = {
        |     ^
    

@SuperSandro2000 SuperSandro2000 merged commit a7a97c9 into NixOS:master Aug 21, 2021
@zowoq zowoq deleted the go-buildflags branch August 21, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants