Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vapor: init at 0.2.3 #13544

Merged
merged 1 commit into from
Mar 5, 2016
Merged

vapor: init at 0.2.3 #13544

merged 1 commit into from
Mar 5, 2016

Conversation

leenaars
Copy link
Contributor

Vapor is a LÖVE distribution client, allowing easy download of LÖVE 0.8 games.

@joachifm joachifm added the 8.has: package (new) This PR adds a new package label Feb 29, 2016
};

nativeBuildInputs = [ lua love ];
buildInputs = [ makeWrapper ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two need to be swapped. nativeBuildInputs should be buildInputs and the other way around.

@leenaars
Copy link
Contributor Author

leenaars commented Mar 5, 2016

@hrdinka: I've swapped them ...

@hrdinka
Copy link
Contributor

hrdinka commented Mar 5, 2016

Great, I have just built and tested it and everything works as expected 👍
The derivation lacks a maintainer. Since you are already maintaining your recent love related packages I guess that you have just missed adding yourself. Further unzip isn't used anywhere and can be removed from the argument list in line 1.

@leenaars
Copy link
Contributor Author

leenaars commented Mar 5, 2016

@hrdinka: added maintainer and removed unzip.

hrdinka added a commit that referenced this pull request Mar 5, 2016
@hrdinka hrdinka merged commit 4e8853c into NixOS:master Mar 5, 2016
@hrdinka
Copy link
Contributor

hrdinka commented Mar 5, 2016

Built & tested locally (linux x86_64). Thanks for contributing! 👍

@leenaars leenaars deleted the vapor branch May 12, 2016 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants