Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fritzing: 0.9.6 -> unstable-2021-09-22 #136142

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Conversation

musfay
Copy link
Contributor

@musfay musfay commented Aug 30, 2021

Motivation for this change

Vendored quazip is outdated.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 30, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 30, 2021

Result of nixpkgs-review pr 136142 at 11f069a9 run on x86_64-linux 1

1 package built successfully:
  • fritzing
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/science/electronics/fritzing/default.nix:85:5:

       |
    85 |     license = with licenses; [ gpl3 cc-by-sa-30 ];
       |     ^
    

Result of nixpkgs-review pr 136142 at 11f069a9 run on aarch64-linux 1

1 package built successfully:
  • fritzing

@musfay musfay changed the title fritzing: drop vendored quazip fritzing: 0.9.6 -> unstable-2021-09-22 Oct 24, 2021
@musfay
Copy link
Contributor Author

musfay commented Oct 25, 2021

Result of nixpkgs-review pr 136142 run on x86_64-linux 1

1 package built:
  • fritzing

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 136142 run on x86_64-linux 1

1 package built:
  • fritzing

@SuperSandro2000 SuperSandro2000 merged commit 66ea992 into NixOS:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants