Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgadmin 1.20.0 -> 1.22.1 #13659

Merged
merged 1 commit into from
Mar 5, 2016
Merged

Conversation

adamgordonbell
Copy link
Contributor

Things done:
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s): NixOS
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @Wyvie, @domenkozar and @edolstra to be potential reviewers

@joachifm joachifm added the 8.has: package (update) This PR updates a package to a newer version label Mar 3, 2016
@joachifm
Copy link
Contributor

joachifm commented Mar 4, 2016

db/keywords.c:33:27: fatal error: parser/kwlist.h: No such file or directory
 #include <parser/kwlist.h>

                           ^
compilation terminated.
Makefile:5536: recipe for target 'db/keywords.o' failed
make[3]: *** [db/keywords.o] Error 1
make[3]: Leaving directory '/tmp/nix-build-pgadmin3-1.22.1.drv-0/pgadmin3-1.22.1/pgadmin'
Makefile:3568: recipe for target 'all' failed

@fpletz
Copy link
Member

fpletz commented Mar 5, 2016

This builds fine for me on the current master, not sure why travis failed.

@fpletz
Copy link
Member

fpletz commented Mar 5, 2016

Restarted travis but it now fails with a merge conflict. Again, not sure why, but I guess this change should be alright as I tested this locally with chroot against master and pgadmin3 works.

fpletz added a commit that referenced this pull request Mar 5, 2016
@fpletz fpletz merged commit beefe9c into NixOS:master Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants