btop: init at 1.0.5

[rmcgibbo]

Motivation for this change

Snazzy resource viewer: https://github.com/aristocratos/btop/blob/main/Img/normal.png

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 139018 at 703ab9f1 run on x86_64-linux 1

1 package built successfully:

• btop

1 suggestion:

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/tools/system/btop/default.nix:17:3:

     |
  17 |   installPhase = ''
     |   ^
  

---

Result of nixpkgs-review pr 139018 at 703ab9f1 run on aarch64-linux 1

1 package failed to build:

• btop

1 suggestion:

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/tools/system/btop/default.nix:17:3:

     |
  17 |   installPhase = ''
     |   ^
  

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

[figsoda]

looks like this line is causing aarch64-linux build to fail
https://github.com/aristocratos/btop/blob/v1.0.5/Makefile#L82

[rmcgibbo]

Interesting. I didn't realize the default version of gcc is different on aarch64-linux.

I switched the package to use gcc11Stdenv.

[figsoda]

Result of nixpkgs-review pr 139018 run on x86_64-linux 1

1 package built:

• btop