Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psi-notify: init at 1.2.1 #139335

Merged
merged 1 commit into from
Sep 24, 2021
Merged

psi-notify: init at 1.2.1 #139335

merged 1 commit into from
Sep 24, 2021

Conversation

eduarrrd
Copy link
Contributor

Motivation for this change

New package I use.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

pkgs/applications/misc/psi-notify/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/psi-notify/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/psi-notify/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/psi-notify/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 24, 2021
@figsoda
Copy link
Member

figsoda commented Sep 24, 2021

upstream has a togglable feature WANT_SD_NOTIFY that can be set to 0 and make the libsystemd dependency optional
https://github.com/cdown/psi-notify/blob/1.2.1/Makefile#L4

maybe it could be added to this package too?

@eduarrrd
Copy link
Contributor Author

Addressed the suggestions, they make sense to me.

upstream has a togglable feature WANT_SD_NOTIFY that can be set to 0 and make the libsystemd dependency optional
https://github.com/cdown/psi-notify/blob/1.2.1/Makefile#L4

maybe it could be added to this package too?

Possibly, but I don't intend to use it without that. We can discuss this once there's a user who intends to use it this way.

@figsoda
Copy link
Member

figsoda commented Sep 24, 2021

fair enough

@figsoda
Copy link
Member

figsoda commented Sep 24, 2021

Result of nixpkgs-review pr 139335 run on x86_64-linux 1

1 package built:
  • psi-notify

@figsoda figsoda merged commit 2ad7295 into NixOS:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants