opencsg: Fix build related to missing libX11 linking the example. #13957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @7c6f434c to be a potential reviewer |
|
Hmm, the build you linked seems to have succeeded. Is this a runtime problem somehow? |
|
Ah, no, it's a failed build but the link was wrong and I couldn't verify due to Hydra being down. Correct link: https://hydra.nixos.org/build/33120256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hydra.nixos.org/build/32684629 (when Hydra starts working again).
I have only seen this happening on release-16.03 not on master. So please merge at least to release-16.03 (yes this PR is against master). I don't completely understand the error but it looks like some logic for the linking might have changed, or dependencies of libraries have changed to cause this.