hipchat: 2.2.1388 -> 4.0.1631

[puffnfresh]

Things done:

• Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
• Built on platform(s)
  • NixOS (x86_64)
  • Linux (x86_64)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

cc @jgeerds

[mention-bot]

By analyzing the blame information on this pull request, we identified @edolstra, @vcunat and @jgeerds to be potential reviewers

[joachifm]

Built this locally. Running result/bin/hipchat fails, however: [...] libexec/hipchat/lib/HipChat.bin: error while loading shared libraries: libGL.so.1: cannot open shared object file: No such file or directory. Not on NixOS.

Probably not a regression, though.

[puffnfresh]

@joachifm does adding mesa on the search path work?

[joachifm]

@puffnfresh yep, but then I get other run-time link errors. Anyway, I'm not too concerned, as I don't intend to use hipchat. I doubt this PR caused the issue, so I'm fine with merging it.

[puffnfresh]

@joachifm it would be great if you posted the linker problems. I'd love to get this working on more systems than mine.

[joachifm]

Sure: https://gist.github.com/joachifm/80443ceca80775e8071e Don't know how useful that is. Looks to me like it can't find qt components. My impression is that some things that should be hardcoded are not.

[copumpkin]

Can we have the HipChat server in Nix as well? 😄

[puffnfresh]

@joachifm I'm not sure why, but it seems your /usr/lib is being picked up and it has a different QT version. It's possible that it would work with the last version (by coincidentally sharing the same version of QT) but also possible that it wouldn't, since I don't think I changed anything around that.

@copumpkin yes, we should have all Atlassian software packaged!

[globin]

@fpletz is at least working on crowd, confluence and jira