ansifilter: add @ 1.15 #14023
ansifilter: add @ 1.15 #14023
Conversation
| let version = "1.15"; | ||
| pkgsha = "65dc20cc1a03d4feba990f830186404c90462d599e5f4b37610d4d822d67aec4"; | ||
| in with pkgs; stdenv.mkDerivation { | ||
| name = "ansifilter"; |
There was a problem hiding this comment.
Please make version a part of the name, as in name = ansifilter-${version}.
|
Please change the commit subject to |
| @@ -12,6 +12,7 @@ | |||
| abbradar = "Nikolay Amiantov <ab@fmap.me>"; | |||
| aboseley = "Adam Boseley <adam.boseley@gmail.com>"; | |||
| adev = "Adrien Devresse <adev@adev.name>"; | |||
| adjective = "Maxwell Huang-Hobbs <mhuan13@gmail.com>"; | |||
There was a problem hiding this comment.
It'd be nice if you'd re-use your GitHub handle here
|
Sorry about the description! That's embarrassing. I implemented the changes you suggested, apart from the makeFlags change. I encountered a weird error where the package build wouldn't actually produce anything if the make flags were specified with makeFlags instead of through configurePhase. This method of passing makeFlags is modeled after the highlight package, from the same people who made ansifilter. |
|
Did you try the |
| @@ -12,6 +12,7 @@ | |||
| abbradar = "Nikolay Amiantov <ab@fmap.me>"; | |||
| aboseley = "Adam Boseley <adam.boseley@gmail.com>"; | |||
| adev = "Adrien Devresse <adev@adev.name>"; | |||
| adjective-object = "Maxwell Huang-Hobbs <mhuan13@gmail.com>"; | |||
There was a problem hiding this comment.
Please make it the exact same as your github handle; this is to make it easier to ping you on github if necessary
|
Updated maintainer name and used |
| sha256 = pkgsha; | ||
| }; | ||
| meta = { | ||
| description = '' |
There was a problem hiding this comment.
Minor nitpick: please remove the newline at the start here; if you want to provide a longer form description, use longDescription.
|
No trouble. Apart from the final nitpick, I think this is ready to merge. |
|
Merged, thanks |
Things done:
nix-build --option build-use-chroot trueor nix.useChroot on NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)More
added package ansifilter @ 1.15