Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove unnecessary vendors of Cargo.lock #140913

Merged
merged 7 commits into from
Oct 8, 2021
Merged

treewide: remove unnecessary vendors of Cargo.lock #140913

merged 7 commits into from
Oct 8, 2021

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Oct 8, 2021

Motivation for this change

sequel to #140864
I will have another sequel targeting staging

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@figsoda figsoda mentioned this pull request Oct 8, 2021
Merged
12 tasks
@ofborg ofborg bot requested review from nrdxp, Ma27, Stupremee and winterqt October 8, 2021 01:35
Stupremee
Stupremee approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@Stupremee Stupremee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool. Didn't knew that was possible!

@figsoda figsoda merged commit 839fb3f into NixOS:master Oct 8, 2021
@figsoda figsoda deleted the remove-cargo-lock branch October 8, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stupremee Stupremee Stupremee approved these changes

@nrdxp nrdxp Awaiting requested review from nrdxp

@Ma27 Ma27 Awaiting requested review from Ma27

@winterqt winterqt Awaiting requested review from winterqt

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@figsoda @Stupremee