Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rspamd 1.2.0 #14106

Merged
merged 1 commit into from
Mar 21, 2016
Merged

Rspamd 1.2.0 #14106

merged 1 commit into from
Mar 21, 2016

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Mar 21, 2016

Things done:
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @obadz, @fpletz and @nbp to be potential reviewers

@avnik
Copy link
Contributor

avnik commented Mar 21, 2016

@zimbatm LGTM ;)

PS I will update rmilter soon as well

@zimbatm
Copy link
Member Author

zimbatm commented Mar 21, 2016

I just saw this on HN. You might want to test the binaries if you use it ^_^

@obadz
Copy link
Contributor

obadz commented Mar 21, 2016

Kinda curious why @mention-bot thought I was a potential reviewer

@zimbatm
Copy link
Member Author

zimbatm commented Mar 21, 2016

@obadz my mistake, I had some unrelated changes bundled when I pushed the branch. By the time I realized mention-bot already had spun into action.

@avnik
Copy link
Contributor

avnik commented Mar 21, 2016

@obadz as well, as it missed me from this list ;)

@zimbatm I cherry-picked your commit, and it works after rebuild/switch

zimbatm added a commit that referenced this pull request Mar 21, 2016
@zimbatm zimbatm merged commit d47fbff into NixOS:master Mar 21, 2016
@zimbatm zimbatm deleted the rspamd-1.2.0 branch March 21, 2016 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants