Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ventoy-bin: 1.0.51 -> 1.0.56 #141616

Merged
merged 5 commits into from
Oct 26, 2021
Merged

ventoy-bin: 1.0.51 -> 1.0.56 #141616

merged 5 commits into from
Oct 26, 2021

Conversation

lxwntr
Copy link
Contributor

@lxwntr lxwntr commented Oct 14, 2021 •
edited
Loading

Version bump

Closes #138094
Closes #141548

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 14, 2021
@Kranzes
Copy link
Member

Kranzes commented Oct 14, 2021

I have mixed feelings about removing the GUI, i personally dont need it and i know most people dont, but at the same time people will want it.

@lxwntr
Copy link
Contributor Author

lxwntr commented Oct 14, 2021

The GUI tool is now included (with options to disable certain variants), however I've ran into a problem on NixOS were the included GUI wrapper is unable to auto-detect what GUI type to use (manual selection is fine).

Tested and working:
ventoy-gui --gtk2
ventoy-gui --gtk3
ventoy-gui --qt5

Working on Fedora+Nix but not NixOS:
ventoy-gui

I will investigate how to solve this.

@lxwntr
Copy link
Contributor Author

lxwntr commented Oct 14, 2021

The upstream GUI wrapper looks for /etc/ld.so.cache to detect what UI toolkit to use, this fails on NixOS. As a workaround a default is now set based on the configured options passed to the nix file. Now everything works on my systems.

@Kranzes
Copy link
Member

Kranzes commented Oct 14, 2021

Hey I will test it in a bit, thanks for all your work on this!

@lxwntr lxwntr requested a review from Artturin October 21, 2021 10:16
lxwntr and others added 3 commits October 22, 2021 11:48
@lxwntr @SuperSandro2000
Update pkgs/tools/cd-dvd/ventoy-bin/default.nix
76f1d45 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@lxwntr @SuperSandro2000
Update pkgs/tools/cd-dvd/ventoy-bin/default.nix
e1a4b09 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@lxwntr
Removed top-level "with lib" expression
89f9069
@lxwntr
Copy link
Contributor Author

lxwntr commented Oct 22, 2021

I've implemented and tested the requested changes. Thank you for your feedback!

Since my initial PR, two new versions of Ventoy were released. Should I updated to the latest version here or open a separate PR after this merges?

@Kranzes
Copy link
Member

Kranzes commented Oct 22, 2021

Update to latest version on this PR, 100%

@lxwntr lxwntr changed the title ventoy-bin: 1.0.51 -> 1.0.54 ventoy-bin: 1.0.51 -> 1.0.56 Oct 22, 2021
@SuperSandro2000 SuperSandro2000 merged commit d8ccdf6 into NixOS:master Oct 26, 2021
@lxwntr lxwntr deleted the ventoy-bin-1.0.54 branch April 6, 2022 09:00
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artturin Artturin Awaiting requested review from Artturin

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ventoy-bin version bump to 1.0.54
5 participants
@lxwntr @Kranzes @SuperSandro2000 @Artturin @Janik-Haag