Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluidsynth_1: remove at 1.1.11 #141918

Merged
merged 1 commit into from
Oct 26, 2021
Merged

fluidsynth_1: remove at 1.1.11 #141918

merged 1 commit into from
Oct 26, 2021

Conversation

sternenseemann
Copy link
Member

Refactor expression a bit, use pname instead of name.

Fixes #141508.
Fixes #124624.

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Stunkymonkey
Stunkymonkey approved these changes Oct 24, 2021
View reviewed changes
Copy link
Contributor

@Stunkymonkey Stunkymonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sternenseemann sternenseemann changed the base branch from master to staging October 25, 2021 23:45
@sternenseemann
fluidsynth_1: remove at 1.1.11
45b3120 
* FluidSynth 1.1.11 was kept around as a dependency of some packages
  that hadn't yet adjusted to API breakages. All of these packages now
  use FluidSynth 2.x, so fluidsynth_1 can be removed. It has been broken
  ever since glib was updated to 2.70 and was affected by an unpatched
  CVE.

* Refactor expression a bit, use pname instead of name.

* Add changelog entry in case someone was using this downstream
  (accidentally?).

Fixes NixOS#141508.
Fixes NixOS#124624.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation labels Oct 25, 2021
@sternenseemann
Copy link
Member Author

@ofborg eval

@SuperSandro2000
Copy link
Member

Since ofborg is broken since a while and no one is fixing it, according to my eye this should eval.

@SuperSandro2000 SuperSandro2000 merged commit 52abab8 into NixOS:staging Oct 26, 2021
@sternenseemann sternenseemann deleted the remove-fluidsynth-1 branch October 26, 2021 10:23
@trofi
Copy link
Contributor

trofi commented Oct 28, 2021

Can you also manually merge staging-next to staging? Looks like it trivially conflicts with other additions: https://dpaste.com/8LKYY7QYP.txt

@alyssais
Copy link
Member

I've taken care of the merge.

@Mindavi Mindavi mentioned this pull request Nov 21, 2021
Closed
10 tasks
@jicksaw jicksaw mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stunkymonkey Stunkymonkey Stunkymonkey approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of now broken fluidsynth_1 Vulnerability roundup 102: fluidsynth-1.1.11: 1 advisory [5.5]
5 participants
@sternenseemann @SuperSandro2000 @trofi @alyssais @Stunkymonkey