Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pytm: init at 1.2.0 #142609

Merged
merged 2 commits into from
Oct 26, 2021
Merged

python3Packages.pytm: init at 1.2.0 #142609

merged 2 commits into from
Oct 26, 2021

Conversation

wamserma
Copy link
Member

Motivation for this change

I want to use pytm on my favourite distro. ;)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wamserma wamserma requested a review from fabaff October 22, 2021 22:08
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 22, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Oct 22, 2021 •
edited
Loading

Result of nixpkgs-review pr 142609 at 0c107743 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.pytm
  • python39Packages.pytm
1 suggestion:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/pytm/default.nix:41:0:

       |
41 |     description = "A Pythonic framework for threat modeling";
   | ^

Result of nixpkgs-review pr 142609 at 0c107743 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.pytm
  • python39Packages.pytm

@wamserma wamserma requested a review from r-burns October 23, 2021 08:17
r-burns
r-burns approved these changes Oct 23, 2021
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wamserma wamserma force-pushed the init-pytm branch 2 times, most recently from c51b84f to 2b9e9ee Compare October 25, 2021 14:58
r-burns
r-burns approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 142609 run on x86_64-linux 1

2 packages built:
  • python38Packages.pytm
  • python39Packages.pytm

@SuperSandro2000 SuperSandro2000 merged commit 86ef6ba into NixOS:master Oct 26, 2021
@wamserma
Copy link
Member Author

@SuperSandro2000 thx for helping with the style fixes and merging!

@wamserma wamserma deleted the init-pytm branch October 26, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@r-burns r-burns r-burns approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wamserma @r-rmcgibbo @SuperSandro2000 @r-burns