Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dunst: 1.6.1 -> 1.7.0 #142716

Merged
merged 1 commit into from
Oct 26, 2021
Merged

dunst: 1.6.1 -> 1.7.0 #142716

merged 1 commit into from
Oct 26, 2021

Conversation

starcraft66
Copy link
Member

Motivation for this change

Update

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from domenkozar October 24, 2021 07:20
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 24, 2021
@danth
Copy link
Contributor

danth commented Oct 24, 2021

Result of nixpkgs-review pr 142716 run on x86_64-linux 1

1 package built:
  • dunst

Copy link
Member

@Kranzes Kranzes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the release message:

Previously the readme said dunst depended on GTK3, which hasn't been the case
for a while. Make sure that GTK3 is not included as a dependency.

There are also some changes to where SYSCONFDIR is set, we might want it to use the new XDG compliant location, please read more about it in the release message here: https://github.com/dunst-project/dunst/releases/tag/v1.7.0

Update pkgs/applications/misc/dunst/default.nix
@starcraft66
Copy link
Member Author

done

@SuperSandro2000 SuperSandro2000 merged commit 1e2ba5f into NixOS:master Oct 26, 2021
@starcraft66 starcraft66 deleted the update-dunst branch October 27, 2021 13:35
@starcraft66 starcraft66 restored the update-dunst branch January 20, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants