Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.libnet: fix Net/libnet.cfg determinism. #142876

Merged
merged 2 commits into from
Oct 26, 2021
Merged

perlPackages.libnet: fix Net/libnet.cfg determinism. #142876

merged 2 commits into from
Oct 26, 2021

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Oct 25, 2021

Closes: #142773

@trofi trofi mentioned this pull request Oct 25, 2021
Closed
@stigtsp
Copy link
Member

stigtsp commented Oct 26, 2021

@GrahamcOfBorg eval

stigtsp
stigtsp requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the patch should be included in pkgs/development/perl-modules as the pr URL might be unstable.

@SuperSandro2000
Copy link
Member

I think the patch should be included in pkgs/development/perl-modules as the pr URL might be unstable.

The URL is unstable but no need to vendor the patch.

@SuperSandro2000
Copy link
Member

@GrahamcOfBorg eval

ofborg is broken currently. No need to manually nudge it.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 142876 run on x86_64-linux 1

6 packages built:
  • dspam
  • git-doc
  • gitFull
  • perl532Packages.libnet
  • perl534Packages.libnet
  • sympa

@SuperSandro2000 SuperSandro2000 merged commit 742101b into NixOS:staging Oct 26, 2021
@trofi trofi deleted the determinixstic-perl-libnet branch October 26, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@stigtsp stigtsp stigtsp requested changes

@zakame zakame Awaiting requested review from zakame

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trofi @stigtsp @SuperSandro2000